feat(HideExpression) add consistent context to function expression #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 86.13% (diff: 0.00%)@@ master #281 diff @@
==========================================
Files 18 18
Lines 642 642
Methods 139 139
Messages 0 0
Branches 152 152
==========================================
Hits 553 553
Misses 89 89
Partials 0 0
|
aitboudad
requested changes
Nov 24, 2016
| @@ -7,7 +7,7 @@ export class FormlyFieldVisibilityDelegate { | |||
| eval(expression: string | Function | boolean): boolean { | |||
| // TODO support this.formlyCommon.field.hideExpression as a observable | |||
| if (expression instanceof Function) { | |||
| return expression(); | |||
| return expression.apply(this.formlyCommon, [this.formlyCommon.model, this.formlyCommon.options.formState]); | |||
There was a problem hiding this comment.
please update FormlyFieldConfig
hideExpression?: boolean | string | ((model, formState) => boolean);
|
How is this feature related to validation? |
franzeal
changed the title
franzeal
force-pushed
the
hideExpression-function-context
branch
from
b786b54 to
27b0383
Compare
|
@mohammedzamakhan Sorry about the incorrect naming. Not sure what I was referencing at the time that lead to my poor choice there. |
aitboudad
approved these changes
Nov 24, 2016
|
Thank you @franzeal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
When hideExpression is a function,
thisandargsof the function are inconsistent with the context when the expression is a string and does not seem to provide useful access to the field.What is the new behavior (if this is a feature change)?
When hideExpression is a function it is called with the same
thisandargsas it would be if it were a string.Please check if the PR fulfills these requirements
npm run buildproduced a successful build. (Unit testing can be done by runningnpm test;)npm run lintto do this.npm run buildwill fail if there are files not linted.)Please provide a screenshot of this feature before and after your code changes, if applicable.
Other information:
This may not be necessary when a hideExpression function is declared in the templateOptions for a field; however, this is intended to address the behavior observed when the hideExpression is declared with a function within the defaultOptions of the formly config.