Expression properties should be able to take function (#148) #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 86.76% (diff: 100%)@@ master #289 diff @@
==========================================
Files 18 18
Lines 642 642
Methods 139 139
Messages 0 0
Branches 152 152
==========================================
+ Hits 553 557 +4
+ Misses 89 85 -4
Partials 0 0
|
aitboudad
approved these changes
Nov 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior? (You can also link to an open issue here)
ExpressionProperties only accept strings - see #148
What is the new behavior (if this is a feature change)?
ExpressionProperties accept strings, booleans and functions - as hideExpression