#230 added methods to extract nested properties & create empty objects

[Krustie101]

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix. In formly form, the fieldModel method assumes that the key is not nested. This bugfix also deals with the case that the key is a nested property (including support for indices, if you really want to use this). The main code is located in the utils class.

Tests have been added for the extra code in the utils class.

What is the current behavior? (You can also link to an open issue here)
See #230

What is the new behavior (if this is a feature change)?

Please check if the PR fulfills these requirements

• The commit messages follow our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
• A unit test has been written for this change.
• Running npm run build produced a successful build. (Unit testing can be done by running npm test;)
• My code has been linted. (npm run lint to do this. npm run build will fail if there are files not linted.)

Please provide a screenshot of this feature before and after your code changes, if applicable.

Other information:

[mohammedzamakhan]

@Krustie101 it worked for me when I did

fieldModel(field: FormlyFieldConfig) {
     if (field.key && (field.fieldGroup || field.fieldArray)) {
       return getFieldModel(this.model, field, true);
     }
     return this.model;
}

[Krustie101]

@mohammedzamakhan That is correct. I also noticed my error, arising from the fact that I did not pay attention that you had changed the meaning of model.

[codecov-io]

Current coverage is 92.62% (diff: 97.36%)

Merging #293 into master will increase coverage by 1.99%

@@             master       #293   diff @@
==========================================
  Files            16         16          
  Lines           672        705    +33   
  Methods         140        143     +3   
  Messages          0          0          
  Branches        163        174    +11   
==========================================
+ Hits            609        653    +44   
+ Misses           63         52    -11   
  Partials          0          0          

Powered by Codecov. Last update fb2fc94...105197b

[mohammedzamakhan]

LGTM 👍

@aitboudad can you have a look at this PR and approve it?

[aitboudad]

@mohammedzamakhan I can't right now :( you can merge it if it looks good,
I'll give my feedback, once I get some time!

[mohammedzamakhan]

@Krustie101 can you also look into using this pattern for assignModelValue in utils.ts#L67 and getValueForKey in utils.ts#L83

[Krustie101]

@mohammedzamakhan I will do, but I am tied up tomorrow. I will look at in on Thursday.

[Krustie101]

The problem lies in the use of formControlName in the FormlyFieldRadio component, this cannot be a nested path. Like in the case of an input the formControlName should be removed and [formControl]="formControl" should be used instead.

I also notice on line 56 of the FormBuilder (master branch) the following check:

if (!form.get(field.key)) {

Should this not be

if (!form.get(rootPath)) {