Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build - close #39 and #42 #46

Merged
merged 7 commits into from
May 26, 2016
Merged

Fix build - close #39 and #42 #46

merged 7 commits into from
May 26, 2016

Conversation

couzic
Copy link
Contributor

@couzic couzic commented May 24, 2016

As stated in #39 and #42 the current npm release (2.0.0-beta.2) has problems. This pull request provides a simple solution, based solely on npm and tsc. However, I ran into problems understanding the previous build system, so I happened to break it. I'm not sure how/where/if it is used, and it seems rather over-complicated, so I wondered if it would be possible to get rid of it completely.

Make npm build consumable by webpack and jspm projects, add Type Definitions and sourcemap files,
reference Type Definitions in package.json, ignore unnecessary files

Bundles are no longer included in npm release, and a lot of the previous jspm-based build system is
circumvented
Make npm run commit use the new tsc-based build system to check for correct compilation before
commit
@mohammedzamakhan
Copy link
Contributor

@micouz the bundles folder is not being created with appropriate js and minified js files, which are used for publishing on cdnjs

@couzic
Copy link
Contributor Author

couzic commented May 25, 2016

@mohammedzamakhan Yes I missed that part. I'll add another commit to this PR.

Add build step to bundle all compiled code into single .js and .min.js files
@mohammedzamakhan
Copy link
Contributor

for the demo to run using gulp play, I have changed the the dest folder to demo in the task ts2js and I see an error which I didn't see in the demo:

browser_adapter.ts:78EXCEPTION: Error in ./FormlyFieldRadio class FormlyFieldRadio - inline template:2:15BrowserDomAdapter.logError @ browser_adapter.ts:78BrowserDomAdapter.logGroup @ browser_adapter.ts:89ExceptionHandler.call @ exception_handler.ts:53(anonymous function) @ application_ref.ts:304schedulerFn @ async.ts:131SafeSubscriber.__tryOrUnsub @ Subscriber.ts:240SafeSubscriber.next @ Subscriber.ts:192Subscriber._next @ Subscriber.ts:133Subscriber.next @ Subscriber.ts:93Subject._finalNext @ Subject.ts:154Subject._next @ Subject.ts:144Subject.next @ Subject.ts:90EventEmitter.emit @ async.ts:117NgZone._zoneImpl.ng_zone_impl_1.NgZoneImpl.onError @ ng_zone.ts:138NgZoneImpl.inner.inner.fork.onHandleError @ ng_zone_impl.ts:90ZoneDelegate.handleError @ zone.js:327Zone.runTask @ zone.js:259ZoneTask.invoke @ zone.js:423
browser_adapter.ts:78ORIGINAL EXCEPTION: Expression has changed after it was checked. Previous value: '[object Object]'. Current value: 'title'BrowserDomAdapter.logError @ browser_adapter.ts:78ExceptionHandler.call @ exception_handler.ts:65(anonymous function) @ application_ref.ts:304schedulerFn @ async.ts:131SafeSubscriber.__tryOrUnsub @ Subscriber.ts:240SafeSubscriber.next @ Subscriber.ts:192Subscriber._next @ Subscriber.ts:133Subscriber.next @ Subscriber.ts:93Subject._finalNext @ Subject.ts:154Subject._next @ Subject.ts:144Subject.next @ Subject.ts:90EventEmitter.emit @ async.ts:117NgZone._zoneImpl.ng_zone_impl_1.NgZoneImpl.onError @ ng_zone.ts:138NgZoneImpl.inner.inner.fork.onHandleError @ ng_zone_impl.ts:90ZoneDelegate.handleError @ zone.js:327Zone.runTask @ zone.js:259ZoneTask.invoke @ zone.js:423
browser_adapter.ts:78ORIGINAL STACKTRACE:

Can you also make sure that demo works fine with all your changes.

Thanks

Make it possible again to run the demo with the 'gulp play' command
When no bundle is built, the script is absent and it showed as an error in browser console
@couzic
Copy link
Contributor Author

couzic commented May 25, 2016

I couldn't reproduce your error, but I had another one of my own. I then tried with a clean checkout of the branch, and for me everything works fine. Could you try again and give me the sequence of steps you take when you see the problem ?
Right now I'm concentrating on getting this PR merged to close the npm release issues, but in the not so distant future I'd like to improve the demo dev environment, using webpack-dev-server.

@mohammedzamakhan mohammedzamakhan merged commit 4b78f81 into ngx-formly:master May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants