-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build - close #39 and #42 #46
Conversation
Make npm build consumable by webpack and jspm projects, add Type Definitions and sourcemap files, reference Type Definitions in package.json, ignore unnecessary files Bundles are no longer included in npm release, and a lot of the previous jspm-based build system is circumvented
Make npm run commit use the new tsc-based build system to check for correct compilation before commit
@micouz the bundles folder is not being created with appropriate js and minified js files, which are used for publishing on cdnjs |
@mohammedzamakhan Yes I missed that part. I'll add another commit to this PR. |
Add build step to bundle all compiled code into single .js and .min.js files
for the demo to run using gulp play, I have changed the the dest folder to demo in the task ts2js and I see an error which I didn't see in the demo:
Can you also make sure that demo works fine with all your changes. Thanks |
Make it possible again to run the demo with the 'gulp play' command
When no bundle is built, the script is absent and it showed as an error in browser console
I couldn't reproduce your error, but I had another one of my own. I then tried with a clean checkout of the branch, and for me everything works fine. Could you try again and give me the sequence of steps you take when you see the problem ? |
As stated in #39 and #42 the current npm release (2.0.0-beta.2) has problems. This pull request provides a simple solution, based solely on npm and tsc. However, I ran into problems understanding the previous build system, so I happened to break it. I'm not sure how/where/if it is used, and it seems rather over-complicated, so I wondered if it would be possible to get rid of it completely.