Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Eliminate the need for the IAM SA keys as Kubernetes secrets #250

Closed
blueandgold opened this issue Sep 11, 2019 · 10 comments
Closed

Eliminate the need for the IAM SA keys as Kubernetes secrets #250

blueandgold opened this issue Sep 11, 2019 · 10 comments
Labels
enhancement New feature or request

Comments

@blueandgold
Copy link
Contributor

It is a best practice not to use security key (whenever possible). But currently for Forseti on GKE, IAM service account key is obtained from GCP and added as a secret to kubernetes.

Per discussion with @kevensen, it is possible to create a dedicated Forseti nodepool in the cluster and bind the SA to the nodes, without using a key. i.e. "taint" these nodes as described above for the sole-use of Forseti.

@blueandgold blueandgold added the enhancement New feature or request label Sep 11, 2019
@morgante
Copy link
Contributor

Instead of using a dedicated node pool, could we use workload identity? https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity

@blueandgold
Copy link
Contributor Author

Workload identity sounds like an interesting idea. Would love to use it if it will solve not having to use a key. @kevensen FYI

@kevensen
Copy link
Contributor

I like that idea. This feature is still in beta. I'd like to make an update to the terraform-google-kubernetes-engine module. Any concerns?

@morgante
Copy link
Contributor

I'm happy to look at a PR for Kubernetes.

@kevensen
Copy link
Contributor

Okeedokee. I'll start there.

@kevensen
Copy link
Contributor

@morgante
Copy link
Contributor

Apologies, it looks like this was already added to the GKE module: terraform-google-modules/terraform-google-kubernetes-engine#234

You should be able to use it directly once the next module is released: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CHANGELOG.md#added

@kevensen
Copy link
Contributor

No worries. It was good practice. I'll look forward to the next release.

@gkowalski-google
Copy link
Contributor

@kevensen Was this addressed with the work for the GKE beta release?

@kevensen
Copy link
Contributor

Yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants