fix: properly locates closing parenthesis in the presence of quotes #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #400 +/- ##
==========================================
+ Coverage 88.14% 88.17% +0.03%
==========================================
Files 35 35
Lines 4790 4795 +5
==========================================
+ Hits 4222 4228 +6
+ Misses 568 567 -1 ☔ View full report in Codecov by Sentry. |
gnikit
force-pushed
the
fix/complicated-kind-args
branch
from
6c879dc to
c71e8a8
Compare
certik
reviewed
May 19, 2024
| if char in quote_state: | ||
| quote_state[char] = not quote_state[char] | ||
| if any(quote_state.values()): | ||
| continue |
There was a problem hiding this comment.
Does this logic work with code like len('ab"c)')?
There was a problem hiding this comment.
In LFortran we parse the string (handling the inner " and such correctly), and then you can locate the parentheses on top (when you see ", just parse the string).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250