Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not treat form feed as line break (#443) #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomoto
Copy link

@tomoto tomoto commented Dec 7, 2024

This is the suggested fix for issue #443. Please see it for the exact description about what this fix is trying to address.

The issue is caused by splitting the code into lines using str.splitlines built-in function, which has a different set of line separators than the editors. (See https://docs.python.org/3/library/stdtypes.html#str.splitlines ) This fix is using our own splitlines function instead to make the line separation rule more consistent with the editors.

Now fortls can return the correct information regardless of the form feed characters in the code.
image

@tomoto tomoto requested a review from gnikit as a code owner December 7, 2024 16:50
@tomoto
Copy link
Author

tomoto commented Dec 7, 2024

@gnikit I see "Some checks were not successful" message. If there are anything I should do, please let me know. Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant