Feature/refactor #58
Merged
Feature/refactor #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 81.72% 84.24% +2.52%
==========================================
Files 9 11 +2
Lines 4372 4361 -11
==========================================
+ Hits 3573 3674 +101
+ Misses 799 687 -112
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
- Moves dataclasses to ftypes submodule - Uses OOP to remove explicit dependance on array indices - Imporves typing hints - Improves docstrings - Simplifies a few code blocks TODO: 1. make process_file a method of `fortran_file` 2. further improve typing hints 3. further improve code quality and design
This method truly belongs inside the class. TODO: investigate if pp variables need to be passed as args The benefit of having the as args in the function level is that we can update them from the server options i.e. config file and pass them
gnikit
force-pushed
the
feature/refactor
branch
from
bba27fc to
7ae210c
Compare
gnikit
commented
Mar 10, 2022
gnikit
force-pushed
the
feature/refactor
branch
from
31d96dd to
00192b1
Compare
ASAP instead of appending to list, whenever that is possible.
Improves code coverage of diagnostics
- Swaps multi-line splits with a stack object for performance - Removes all the indices that were used for lines and comments - Simplifies documentation parsing in preparation of rewrite
This should make it easier to extend the parsing documentation functionality of FORD and Doxygen in the future
gnikit
force-pushed
the
feature/refactor
branch
from
6dbb434 to
d2ff31a
Compare
- Removes self.line - Improves funcion names
Also adds Doxygen and FORD traditional style tests instead of edge cases
- Added unittests for renaming - Properly implemented solution for hansec/fortran-language-server#104 Now it does not add to the source code. - Improves coverage of renaming and all_references - Added warnings for edge cases i.e. renaming intrinsics
Updates the solution with the number of references present for vector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to further simplify the servers design, make maintainace easier and improve performance where possible.
Changes
TODO:
process_filea method offile_obj, namedparsewhich resoves file objects contents and produces an AST fileprocess_filerewrite everyif ...: continueblock to be a separate methodConsider changing the constructors inobjectsto receive their corresponding dataclass objectjson_templates.pywith functions for generating json boilerplate code