Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMP continuation not triggering correctly #225

Closed
jefflarkin opened this issue Apr 19, 2021 · 3 comments · Fixed by #224
Closed

OpenMP continuation not triggering correctly #225

jefflarkin opened this issue Apr 19, 2021 · 3 comments · Fixed by #224

Comments

@jefflarkin
Copy link

While I was testing the OpenACC directive support I discovered that the OpenMP continuation (and thus the OpenACC continuation) does not highlight properly if the optional & appears on the continued line's sentinel. I tried to debug this myself as a part of the PR, but even with a few sets of eyes on it I wasn't able to get it working.

!$omp parallel &
!$&omp do 

For the above code, if either & is left off the do will appropriately highlight, but if both are in place it does not. The specification allows for the ampersand on the sentinel and this is how I've seen it used in every code I've encountered.

@gnikit
Copy link
Member

gnikit commented Apr 19, 2021

I think the solution to that might be similar (or hopefully identical to #203).
If that is the case and you decide to fix it yourself would you mind to mention #203 in the commit message so this code duplication is somewhat traceable in the git logs?

We really ought to find a better way to implement the syntax highlighting

@jefflarkin
Copy link
Author

It looks like re-using that fix did do the trick. I had intended to submit a separate PR, but accidentally included the fix in #224 .

@gnikit
Copy link
Member

gnikit commented Jun 30, 2021

Glad to hear that. I will have a look at the PR

@gnikit gnikit linked a pull request Jun 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants