Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF 2006 issues #33

Open
YoYo178 opened this issue Jun 24, 2024 · 10 comments
Open

FF 2006 issues #33

YoYo178 opened this issue Jun 24, 2024 · 10 comments
Labels
enhancement New feature or request

Comments

@YoYo178
Copy link
Member

YoYo178 commented Jun 24, 2024

This is an official issue page to track FF 2006's issues/enhancements that have been fixed/implemented in FF 2013.

@YoYo178 YoYo178 added the enhancement New feature or request label Jun 24, 2024
@YoYo178
Copy link
Member Author

YoYo178 commented Jun 24, 2024

As of now,
fortressforever/fortressforever#105 was implemented in commit 94e4c2f.
fortressforever/fortressforever#204 was implemented in commit 5444097.

@BreakinBenny
Copy link
Collaborator

The Valve MP3 Player was kinda fun, but we have YouTube and other applications for that these days… and MP3 usage in this mod can be retained because FF isn't commercial anyway.

@YoYo178
Copy link
Member Author

YoYo178 commented Jun 24, 2024

Fixed fortressforever/fortressforever#65 in commit c28f86f.

@YoYo178
Copy link
Member Author

YoYo178 commented Jun 25, 2024

Implemented fortressforever/fortressforever#71 in commit 97a0537.

Examples of usage are in the commit's description.

@YoYo178
Copy link
Member Author

YoYo178 commented Jun 25, 2024

Implemented fortressforever/fortressforever#226 in commit 06a7063.

@YoYo178
Copy link
Member Author

YoYo178 commented Jun 25, 2024

@BreakinBenny
Copy link
Collaborator

Some Demoman-related hints and strings show the localization tag, rather than the intended text.

@YoYo178
Copy link
Member Author

YoYo178 commented Jul 3, 2024

Implemented fortressforever/fortressforever#112 in commit 4fe12e6.

Usage:

function ondeathnotice( event )
    [...]
    return EVENT_ALLOWED;
end

The above function is fired on these events:

  • player_death
  • sentrygun_killed
  • dispenser_killed
  • mancannon_killed
  • objective_event (This refers to any objective notice that is fired from LUA)

One can also check for the event type by comparing the above strings with the event:GetName() function

Event functions:

event:GetName()
event:IsEmpty(string)

event:GetInt(string)
event:GetBool(string)
event:GetFloat(string)
event:GetString(string)

event:SetInt(string, int)
event:SetBool(string, bool)
event:SetFloat(string, float)
event:SetString(string, string)

All of the above functions accept a key (getters, setters, and IsEmpty()) and a value (setters only).
The key can be one of the following:

  • userid (integer, in all events)
  • attacker (integer, in all events except objective_event)
  • weapon (string, in all events except objective_event)
  • damagetype (integer, only in player_death)
  • customkill (integer, only in player_death)
  • killassister (integer, only in player_death)
  • killersglevel (integer, in all events except objective_event)
  • killedsglevel (integer, only in player_death and sentrygun_killed)
  • attackerpos (vector string, i.e "120 90 60", only in sentrygun_killed)
  • eventtext (string, only in objective_event)

Note - Make sure to test if the key exists first with event:IsEmpty() before using Getter functions because event:GetBool() function will return false if the key is set to false OR if the key doesn't exist, this is also the case with every other Getter function.

This feature will be further improved to include constant variables instead of using strings.

@YoYo178
Copy link
Member Author

YoYo178 commented Jul 3, 2024

Implemented fortressforever/fortressforever#120 in commit 4c5443c.

image

@BreakinBenny
Copy link
Collaborator

fortressforever/fortressforever#397
BreakinBenny@25275d4

Do we allow the jetpack? Can be used if we want to disallow while carrying flag, or to prevent trivializing some jump maps that predate the jetpack's implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants