You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that having separate methods to define record types and transform functions are unnecessary and that they should be defined up front in the constructor. This makes setup more declarative, removes possible user error of redefining types and transforms, and also allows the adapter connect method to be automatically called upon instantiation.
This makes connect to be called automatically, removes defineType, transform, transformInput, transformOutput, and would require a new major version. I would also like to remove the deprecated create method as well.
I'd also like to change the return value of the default export, it should return a Promise which resolves to the instance when connection is done.
Overall these changes would reduce unnecessary complexity in instantiating Fortune.js.
The text was updated successfully, but these errors were encountered:
I think that having separate methods to define record types and transform functions are unnecessary and that they should be defined up front in the constructor. This makes setup more declarative, removes possible user error of redefining types and transforms, and also allows the adapter
connect
method to be automatically called upon instantiation.The new constructor could look like this:
This makes
connect
to be called automatically, removesdefineType
,transform
,transformInput
,transformOutput
, and would require a new major version. I would also like to remove the deprecatedcreate
method as well.I'd also like to change the return value of the default export, it should return a
Promise
which resolves to the instance when connection is done.Overall these changes would reduce unnecessary complexity in instantiating Fortune.js.
The text was updated successfully, but these errors were encountered: