-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reachability] Scan summary and better docs #1379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meghfossa
changed the title
better ux and docs for reachability
[Reachability] Scan summary and better docs
Feb 13, 2024
meghfossa
commented
Feb 13, 2024
@@ -70,3 +72,9 @@ data ParsedJar = ParsedJar | |||
deriving (Eq, Ord, Show, Generic) | |||
|
|||
instance ToJSON ParsedJar | |||
|
|||
reachabilityRawJson :: Text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid circular imports
meghfossa
requested review from
csasarak and
jssblck
and removed request for
csasarak
February 13, 2024 03:16
jssblck
approved these changes
Feb 14, 2024
Co-authored-by: Jessica Black <me@jessica.black>
Co-authored-by: Jessica Black <me@jessica.black>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR,
Acceptance criteria
Testing plan
OrgId
does not support reachability message, if your org does not support reachabilityRisks
N/A
Metrics
N/A
References
https://fossa.atlassian.net/browse/ANE-1416
docs/
.docs/README.ms
and gave consideration to how discoverable or not my documentation is.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
AND I have updated example files used byfossa init
command. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.