Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoTicket] Fixes fossa test output #1403

Merged
merged 2 commits into from
Mar 28, 2024
Merged

[NoTicket] Fixes fossa test output #1403

merged 2 commits into from
Mar 28, 2024

Conversation

meghfossa
Copy link
Contributor

@meghfossa meghfossa commented Mar 28, 2024

Overview

This PR, improves the legibility of diagnostic message. Previously, fossa-cli was not adding necessary spaces between license and dependency.

CleanShot 2024-03-28 at 00 21 08@2x

Acceptance criteria

  • There is space between license and dependency, when policy failure occurs

Testing plan

  1. git checkout master && git pull origin && git checkout fix/fossa-test-fmt && make install-dev
  2. Add file fossa-deps.yml
# sandbox/fossa-deps.yml
referenced-dependencies:
- type: npm
  name: next
  version: 14.1.0
echo 'numpy' > reqs.txt
fossa analyze && fossa test 

You should see space between license and dependency

Risks

N/A

Metrics

N/A

References

N/A

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@meghfossa meghfossa marked this pull request as ready for review March 28, 2024 06:22
@meghfossa meghfossa requested a review from a team as a code owner March 28, 2024 06:22
@meghfossa meghfossa requested a review from csasarak March 28, 2024 06:22
@meghfossa meghfossa merged commit 0afaea1 into master Mar 28, 2024
16 checks passed
@meghfossa meghfossa deleted the fix/fossa-test-fmt branch March 28, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants