Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put files in subdir when extracting #1425

Merged
merged 2 commits into from
May 3, 2024
Merged

Don't put files in subdir when extracting #1425

merged 2 commits into from
May 3, 2024

Conversation

jssblck
Copy link
Member

@jssblck jssblck commented May 2, 2024

Overview

Updates the EmbeddedBinary logic to suffix the fossa-vendor directory name with a UUID instead of nesting a UUID folder inside.

This provides complete isolation to multiple callers, such that even if they (or a system process) cleans up the parent after they're done they don't mess with other callers.

Acceptance criteria

Integration tests pass again

Testing plan

Relying on integration tests- if this breaks anything with extraction we'll get way more errors, if this fixes the issue observed in other PRs we'll get none.

Risks

None

Metrics

None

References

Resolves https://fossa.atlassian.net/browse/ANE-1742

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@jssblck jssblck marked this pull request as ready for review May 2, 2024 23:50
@jssblck jssblck requested a review from a team as a code owner May 2, 2024 23:50
Copy link
Contributor

@csasarak csasarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for tracking that down!

@jssblck jssblck merged commit 20aea27 into master May 3, 2024
16 checks passed
@jssblck jssblck deleted the fix/ane1742 branch May 3, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants