Don't put files in subdir when extracting #1425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the
EmbeddedBinary
logic to suffix thefossa-vendor
directory name with a UUID instead of nesting a UUID folder inside.This provides complete isolation to multiple callers, such that even if they (or a system process) cleans up the parent after they're done they don't mess with other callers.
Acceptance criteria
Integration tests pass again
Testing plan
Relying on integration tests- if this breaks anything with extraction we'll get way more errors, if this fixes the issue observed in other PRs we'll get none.
Risks
None
Metrics
None
References
Resolves https://fossa.atlassian.net/browse/ANE-1742
Checklist
docs/
.docs/README.ms
and gave consideration to how discoverable or not my documentation is.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
AND I have updated example files used byfossa init
command. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.