Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI tests #17

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Fix CircleCI tests #17

merged 3 commits into from
Feb 15, 2018

Conversation

elldritch
Copy link
Member

This PR resolves test breakage resulting from #15. It works by doing integration testing using the in-repository test fixtures and spinning up a Docker image with all the required test tools.

Future work:

  • Figuring out how to do unit tests (get rid of effects 🎉 or maybe dependency injection?)
  • Getting JUnit test reports in CircleCI (looks like Ginkgo is a good fit for use as a testing library)

Copy link
Member

@lackstein lackstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elldritch
Copy link
Member Author

Overriding license check: dependencies are being overreported, and this will be fixed by dogfooding the CLI in a coming PR.

@elldritch elldritch merged commit fedeca4 into master Feb 15, 2018
@elldritch elldritch deleted the fix/circleci-tests branch March 1, 2018 20:17
meghfossa pushed a commit that referenced this pull request Nov 12, 2021
* Add python strategy docs

* Add golang strategy docs

* Add nodejs strategy docs

* Add maven strategy docs

* Add gradle strategy docs

* Add ruby strategy docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants