Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotional Code empty still calls server #3815

Closed
codedsun opened this issue Jan 17, 2020 · 6 comments · Fixed by #3818
Closed

Promotional Code empty still calls server #3815

codedsun opened this issue Jan 17, 2020 · 6 comments · Fixed by #3818

Comments

@codedsun
Copy link
Contributor

Describe the bug
The Apply promo code section while ordering tickets for an event hits the API even when the promocode text field is empty.

To Reproduce

  1. Open the page for ordering ticket
  2. Click on apply promocode
  3. Click on tick without entering any value -Hits the API

Expected behaviour
Shouldn't hit api and should be handled client side.

Screenshots

image

@maze-runnar
Copy link
Contributor

@codesun , i want to work on this.

@maze-runnar
Copy link
Contributor

@codedsun so it should validate from client side when promotion code field is empty?

@maze-runnar
Copy link
Contributor

@codedsun , what about this solution -
make the submit promotional code button dissappear when there is not any promotionalCode,and i made frontend validation working too -
Screenshot from 2020-01-18 14-42-45

Screenshot from 2020-01-18 14-38-57
Screenshot from 2020-01-18 14-39-02

@codedsun
Copy link
Contributor Author

make the submit promotional code button dissappear when there is not any promotionalCode

See how it's working for other input fields. This also looks good to me.

@maze-runnar
Copy link
Contributor

make the submit promotional code button dissappear when there is not any promotionalCode

See how it's working for other input fields. This also looks good to me.

@codedsun can you please make me clear , what you mean by other input fields here?

@codedsun
Copy link
Contributor Author

@maze-runnar - I meant that refer to the other input fields used in the project for taking reference. Rest it also looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants