Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Internal Models For Notification Contents and Video Channels #9116

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

thealphadollar
Copy link
Contributor

@thealphadollar thealphadollar commented Dec 16, 2023

Fixes #

Short description of what this resolves:

  • Adds two internal models (not exposed via API).

Changes proposed in this pull request:

  • add: notification_contents internal model
  • add: video_channels internal model

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@norbusan
Copy link
Member

THanks, that looks nice, but I think it would be better if the introduction of the basic model is paired with the serializer, the views, and the URL definition, not to split all of it apart.

WDYT?

@norbusan norbusan merged commit dcba90c into fossasia:dev-v3 Dec 17, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants