Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button Group] margin-bottom #8575

Closed
andycochran opened this issue Apr 11, 2016 · 4 comments · Fixed by #8616
Closed

[Button Group] margin-bottom #8575

andycochran opened this issue Apr 11, 2016 · 4 comments · Fixed by #8616

Comments

@andycochran
Copy link
Contributor

If Button Groups have enough Buttons to wrap to multiple lines, the lines are flush against each other. Should we add margin-bottom: $buttongroup-spacing?

Here's an example showing before/after this proposed fix:
http://codepen.io/andycochran/pen/jqZYMX

Relatedly, how does this effect button radius (e.g. #8447 Should radius go on the button or the group)?

@Owlbertz
Copy link
Contributor

+1 for the margin-bottom from my side.
Also, personally I always liked the radius for the whole group better.

@brettsmason
Copy link
Contributor

I agree with @Owlbertz on everything! Looks good.

@andycochran
Copy link
Contributor Author

I agree, @Owlbertz; radius on the whole group makes sense most of the time. But not all the time. I'm not sure how radius on the group works with this multi-line case.

@phifa
Copy link
Contributor

phifa commented Apr 12, 2016

+1 radius on whole group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants