targets: Add missing fields to TufCustom #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fioctl targets add` command must retain the arch and image-file custom fields from the previous target. Otherwise, the publish-compose-apps operation for new targets will fail. This commit adds both field to the structure used in the process, allowing the required fields to be copied to the target being added. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
mike-sul
approved these changes
Nov 12, 2024
|
@detsch This change LGTM, and it fixes the issue you have in mind. I would use this PR to fix another related issue - the So, I think we should set |
mike-sul
approved these changes
Nov 13, 2024
|
@detsch Let's rebase and merge it, and the |
|
@vkhoroz It would be great to include this commit into the upcoming release too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fioctl targets addcommand must retain the arch and image-file custom fields from the previous target. Otherwise, the publish-compose-apps operation for new targets will fail.This commit adds both field to the structure used in the process, allowing the required fields to be copied to the target being added.
@mike-sul after some additional tests with targets creation, it is clear that this change is in fact required.