Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add "changePrank" variant #319

Merged
merged 1 commit into from
Mar 5, 2023
Merged

feat: add "changePrank" variant #319

merged 1 commit into from
Mar 5, 2023

Conversation

PaulRBerg
Copy link
Contributor

Adds a changePrank invariant that accepts a new parameter tx.origin for changing the msg.sender and the tx.origin at the same time.

mds1
mds1 approved these changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mds1 mds1 merged commit dc1901f into foundry-rs:master Mar 5, 2023
@holic
Copy link

holic commented Mar 6, 2023 •
edited
Loading

unrelated but ooc, what happens if you just startPrank again without calling stopPrank first? do pranks "stack"?

answered my own question:

[FAIL. Reason: You have an active prank already.]

@PaulRBerg
Copy link
Contributor Author

@holic FYI, the best places to ask this sort of question are:

@PaulRBerg PaulRBerg deleted the change-prank branch March 6, 2023 08:02
@PaulRBerg PaulRBerg mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulRBerg @holic @mds1