-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow some cheatcodes for precompiles #1159
Comments
One observation is that An alternative might be to issue a warning when this is seen, instead of disallowing. Also, I've noticed a few other addresses have been problematic in my tests that might be worth adding to this list:
|
For reference:
Also, the last 4 addresses in the above comment should probably all have default labels set if they don't already. |
Taking this one on @mds1 — was wondering, do we wanna just warn or should we just disallow? |
I think we should disallow
vm.etch
for addresses 0 < n < 10, and throw an error about using an address >10.I prefer breaking these early and getting "correct" behavior vs hacking something on Revm.
(This should be fine for transfers etc on the <10 addresses and seems only a vm.etch issue?)
Originally posted by @gakonst in #1146 (comment)
Worth considering disallowing other cheatcodes for those addresses. It's not realistic to
prank
that address ormockCall
with it, and you also don't want tosave
orload
slots from there, for example.As for what addresses to block off, to be safe we might also want to:
etch
ing at addresses that other chains have predeployed contracts at. For example Optimism has predeployed contracts at0x420...000
< n <0x420...013
, not sure about other networks offhandOriginally posted by @mds1 in #1146 (comment)
This is a breaking change
The text was updated successfully, but these errors were encountered: