Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: could not compile foundry-common due to no field functions on type std::string::String #3416

Closed
2 tasks
sambacha opened this issue Sep 29, 2022 · 3 comments · Fixed by #3417
Closed
2 tasks
Labels
T-bug Type: bug

Comments

@sambacha
Copy link
Contributor

Component

Other (please describe)

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

macOS (Intel)

Describe the bug

When using foundry-common as a dependency I am now running into this:

error[E0609]: no field `functions` on type `std::string::String`
   --> /Users/sbacha/.cargo/git/checkouts/foundry-f7cca724e93059b0/b25f321/common/src/abi.rs:271:30
    |
271 |     let funcs = metadata.abi.functions.get(function_name).unwrap_or(&empty);
    |                              ^^^^^^^^^ unknown field

For more information about this error, try `rustc --explain E0609`.
error: could not compile `foundry-common` due to previous error
@sambacha sambacha added the T-bug Type: bug label Sep 29, 2022
@gakonst gakonst added this to Foundry Sep 29, 2022
@gakonst gakonst moved this to Todo in Foundry Sep 29, 2022
@mattsse
Copy link
Member

mattsse commented Sep 29, 2022

there's a breaking change in this PR gakonst/ethers-rs#1757 which will be added here shortly.

since you have it as a dependency, you'd need to patch ethers-rs dependency until that lands

@sambacha
Copy link
Contributor Author

there's a breaking change in this PR gakonst/ethers-rs#1757 which will be added here shortly.

since you have it as a dependency, you'd need to patch ethers-rs dependency until that lands

any ETA for that to land?

Appreciate the heads up!

@mattsse
Copy link
Member

mattsse commented Sep 29, 2022

I think @DaniPopes is on it

Repository owner moved this from Todo to Done in Foundry Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants