Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading mnemonic + HD path as encrypted keystore #3818

Closed
0x8f701 opened this issue Dec 2, 2022 · 3 comments
Closed

Support loading mnemonic + HD path as encrypted keystore #3818

0x8f701 opened this issue Dec 2, 2022 · 3 comments
Labels
C-cast Command: cast T-feature Type: feature

Comments

@0x8f701
Copy link

0x8f701 commented Dec 2, 2022

Component

Cast

Describe the feature you would like

Currently cast only support generating random keypair, it'll be great to support creating encrypted keystore using existing mnemonic + HD path.

Metamask didn't support exporting as encrypted json. That's why I'm seeking tools to export without re-inventing wheels

Additional context

No response

@0x8f701 0x8f701 added the T-feature Type: feature label Dec 2, 2022
@0x8f701 0x8f701 changed the title Support load mnemonic + HD path as encrypted keystore Support loading mnemonic + HD path as encrypted keystore Dec 2, 2022
@rkrasiuk rkrasiuk added the C-cast Command: cast label Dec 5, 2022
@PatrickAlphaC
Copy link

An API like:

cast wallet import <NAME> <KEY>

Which then prompts the user for a password, and ecrypts it locally. Somewhere like:

~/.cast/wallets/<name>_keystore.json

Then, have a command to list stored keystores:

cast wallet list

And, then, when deploying commands with forge or cast, add the option to prompt the user to decrypt their password:

$ forge script script/Deploy.s.sol --rpc-url $RPC_URL --cast-wallet <WALLET_NAME>

enter password to decrypt <WALLET_NAME>
_

Or

$ cast send [TO] [SIG] [ARGS] --cast-wallet <WALLET_NAME>

enter password to decrypt <WALLET_NAME>
_

@robbiesumner
Copy link

I believe this feature has been added in #5551. Should this issue be closed?

@Evalir
Copy link
Member

Evalir commented Feb 25, 2024

Done on #5551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cast Command: cast T-feature Type: feature
Projects
None yet
Development

No branches or pull requests

5 participants