Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(forge): forge create should install dependencies #4361

Closed
CodeSandwich opened this issue Feb 15, 2023 · 0 comments · Fixed by #9401
Closed

bug(forge): forge create should install dependencies #4361

CodeSandwich opened this issue Feb 15, 2023 · 0 comments · Fixed by #9401
Labels
A-installer Area: installer C-forge Command: forge Cmd-forge-create Command: forge create P-low Priority: low T-bug Type: bug T-to-investigate Type: to investigate
Milestone
v1.0.0

Comments

@CodeSandwich
Copy link
Contributor

CodeSandwich commented Feb 15, 2023 •
edited by grandizzy
Loading

Component

Forge

Describe the feature you would like

Both forge build and forge test internally call forge install if they detect that the dependencies aren't checked out. forge create on the other hand doesn't seem to do that, it requires manually running forge install or it fails. This makes writing scripts trickier, because the script dev will probably have the project fully installed, but the script operator may have a fresh clone without dependencies fetched, so the script will fail.

It'd be great if forge create internally called forge install.

Additional context

No response
@CodeSandwich CodeSandwich added the T-feature Type: feature label Feb 15, 2023
@gakonst gakonst added this to Foundry Feb 15, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Feb 15, 2023
@zerosnacks zerosnacks added C-cast Command: cast C-forge Command: forge A-installer Area: installer labels Jun 28, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@zerosnacks zerosnacks removed the C-cast Command: cast label Oct 10, 2024
@zerosnacks zerosnacks changed the title Cast create to install dependencies bug(forge): forge create should install dependencies Oct 10, 2024
@zerosnacks zerosnacks added Cmd-forge-create Command: forge create T-bug Type: bug T-to-investigate Type: to investigate and removed T-feature Type: feature labels Oct 10, 2024
@grandizzy grandizzy added the P-low Priority: low label Nov 19, 2024
@grandizzy grandizzy mentioned this issue Nov 25, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-installer Area: installer C-forge Command: forge Cmd-forge-create Command: forge create P-low Priority: low T-bug Type: bug T-to-investigate Type: to investigate
Projects
Foundry
Archived in project
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix(forge create): install missing deps if any grandizzy/foundry
3 participants
@CodeSandwich @grandizzy @zerosnacks