Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forge script --unlocked without --sender #4822

Closed
adhusson opened this issue Apr 25, 2023 · 0 comments · Fixed by #7742
Closed

Allow forge script --unlocked without --sender #4822

adhusson opened this issue Apr 25, 2023 · 0 comments · Fixed by #7742
Labels
C-anvil Command: anvil C-forge Command: forge Cmd-forge-script Command: forge script T-feature Type: feature

Comments

@adhusson
Copy link
Contributor

Component

Forge

Describe the feature you would like

Running simulation scripts against anvil instances would be easier if --unlocked without --sender was OK. You would use whatever the sender gets resolved to for each broadcast(...).

Here:

let mut senders = HashSet::from([self
.evm_opts
.sender
.wrap_err("--sender must be set with --unlocked")?]);
// also take all additional senders that where set manually via broadcast
senders.extend(
deployment_sequence
.typed_transactions()
.iter()
.filter_map(|(_, tx)| tx.from().copied()),
);

Additional context

No response

@adhusson adhusson added the T-feature Type: feature label Apr 25, 2023
@gakonst gakonst added this to Foundry Apr 25, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Apr 25, 2023
@mds1 mds1 added C-forge Command: forge C-anvil Command: anvil Cmd-forge-script Command: forge script labels Apr 25, 2023
@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-anvil Command: anvil C-forge Command: forge Cmd-forge-script Command: forge script T-feature Type: feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants