Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: establish release channels #494

Open
onbjerg opened this issue Jan 18, 2022 · 3 comments
Open

feat: establish release channels #494

onbjerg opened this issue Jan 18, 2022 · 3 comments
Assignees
Labels
A-releases Area: releases/packaging D-average Difficulty: average P-normal Priority: normal
Milestone

Comments

@onbjerg
Copy link
Member

onbjerg commented Jan 18, 2022

I think we need a better construct for release channels. For nightly the setup in this PR works fine, but for stable it does not: the primary tag of the release is not a stable-$SHA tag, it's a vx.y.z tag. I looked at GitHub's API and there is no way for us to get all tags pointing to a specific commit unless we literally just iterate over all tags in the repository (worst case).

An alternative would be to have some file that just describes the latest release in each channel like:

nightly: nightly-$SHA
stable: v1.0.2

Note that it is not a JSON file or something similar: it is easy to parse in both Node.js (for the action) and Bash (for foundryup). The question is where to host this file.

Originally posted by @onbjerg in #492 (comment)

@onbjerg onbjerg added T-meta Type: meta A-releases Area: releases/packaging D-average Difficulty: average and removed T-meta Type: meta labels Jan 19, 2022
@onbjerg onbjerg added this to the v1.0.0 milestone Jul 1, 2022
@onbjerg onbjerg removed this from the v1.0.0 milestone Aug 23, 2022
@lucas-manuel
Copy link

Close-able? @mds1

@mds1
Copy link
Collaborator

mds1 commented May 18, 2023

Leaving open for v1.0.0 since we might have a different release process at that point, assigning to @Evalir

@mds1
Copy link
Collaborator

mds1 commented May 18, 2023

Consider release checksums as mentioned in #495 as part of this, along with apt/brew distributions in #20

@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@zerosnacks zerosnacks changed the title Release channels feat: establish release channels Jul 31, 2024
@zerosnacks zerosnacks added the P-normal Priority: normal label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-releases Area: releases/packaging D-average Difficulty: average P-normal Priority: normal
Projects
No open projects
Status: Todo
Development

No branches or pull requests

5 participants