Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: rename vm.skip to vm.skipTest #5837

Closed
mds1 opened this issue Sep 15, 2023 · 1 comment
Closed

suggestion: rename vm.skip to vm.skipTest #5837

mds1 opened this issue Sep 15, 2023 · 1 comment
Assignees
Labels
A-cheatcodes Area: cheatcodes T-feature Type: feature
Milestone

Comments

@mds1
Copy link
Collaborator

mds1 commented Sep 15, 2023

Component

Forge

Describe the feature you would like

In #5205 vm.skip(bool) cheat was added to skip tests. However for a long time forge-std has had skip which skips forward in time.

The latter has been around longer, and skipTest is more explicit, so I'd suggest renaming the vm.skip cheat to vm.skipTest

If people agree with this change, let's introduce vm.skipTest now and remove vm.skip as part of the v1 release

Additional context

No response

@mds1 mds1 added T-feature Type: feature A-cheatcodes Area: cheatcodes labels Sep 15, 2023
@gakonst gakonst added this to Foundry Sep 15, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Sep 15, 2023
@Evalir Evalir added this to the v1.0.0 milestone Sep 15, 2023
@Evalir Evalir self-assigned this Sep 15, 2023
@PraneshASP
Copy link
Contributor

Agreed that it is confusing to use skip for both. In favor of using skipTest(). Can take this on if needed. lmk

@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cheatcodes Area: cheatcodes T-feature Type: feature
Projects
Archived in project
Development

No branches or pull requests

4 participants