Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter - preserve hex underscore #6361

Closed
radeksvarz opened this issue Nov 19, 2023 · 0 comments · Fixed by #6417
Closed

Formatter - preserve hex underscore #6361

radeksvarz opened this issue Nov 19, 2023 · 0 comments · Fixed by #6417
Labels
Cmd-forge-fmt Command: forge fmt good first issue Good for newcomers

Comments

@radeksvarz
Copy link

case:

hex"6001_6002_53" is not preserved (is reformatted to hex"6001600253") when forge fmt is executed even when number_underscore is set to preserve

Proposal:

create a separate fmt config key for hex_underscore with preserve / remove options, default = preserve
@Evalir Evalir transferred this issue from foundry-rs/book Nov 19, 2023
@mattsse mattsse added Cmd-forge-fmt Command: forge fmt good first issue Good for newcomers labels Nov 20, 2023
@mattsse mattsse mentioned this issue Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cmd-forge-fmt Command: forge fmt good first issue Good for newcomers
Projects
Foundry Book
Status: Done
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add hex underscore fmt rule mattsse/foundry
2 participants
@radeksvarz @mattsse