Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional feature to enable faster keccak implementation #6678

Closed
DaniPopes opened this issue Dec 28, 2023 · 2 comments · Fixed by #6941
Closed

Add optional feature to enable faster keccak implementation #6678

DaniPopes opened this issue Dec 28, 2023 · 2 comments · Fixed by #6941
Labels
first issue A good way to start contributing T-feature Type: feature T-perf Type: performance

Comments

@DaniPopes
Copy link
Member

Component

Other (please describe)

Describe the feature you would like

See alloy-rs/core#466 (released in v0.5.4), and paradigmxyz/reth#5874.

It should also enable this feature by default when creating distribution binaries in CI, since that's where the biggest speed up is.

Additional context

No response
@DaniPopes DaniPopes added first issue A good way to start contributing T-feature Type: feature T-perf Type: performance labels Dec 28, 2023
@gakonst gakonst added this to Foundry Dec 28, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 28, 2023
@MuhtasimTanmoy
Copy link

Details, high-level design, and testing procedures are needed.

@1010adigupta
Copy link
Contributor

understood, I can take this up

@DaniPopes DaniPopes mentioned this issue Jan 29, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first issue A good way to start contributing T-feature Type: feature T-perf Type: performance
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add asm-keccak feature foundry-rs/foundry
3 participants
@MuhtasimTanmoy @DaniPopes @1010adigupta