Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundry release process is not hermetic #7044

Open
2 tasks done
sambacha opened this issue Feb 8, 2024 · 1 comment
Open
2 tasks done

Foundry release process is not hermetic #7044

sambacha opened this issue Feb 8, 2024 · 1 comment
Labels
A-releases Area: releases/packaging T-bug Type: bug
Milestone

Comments

@sambacha
Copy link
Contributor

sambacha commented Feb 8, 2024

Component

Forge, Cast, Anvil, Chisel

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

No response

Operating System

macOS (Apple Silicon)

Describe the bug

The releases for the binaries are not published hermetically: the github bot will start the release process and as the workflows finish independent of each other, piecewise upload the respective binaries.

Example from the release that just finished a few minutes ago
for nightly-a5efe4f8f425e2f6fb35b0e298f0f46acce11dad

2024-02-08T00:48:19Z foundry_nightly_darwin_amd64.tar.gz
2024-02-08T00:30:28Z foundry_nightly_linux_arm64.tar.gz

The release process shouldn't be made public until all binaries are compiled, it makes sense as a fault in the build process in one supported OS should mean the release is not correct. Additionally there are some edge cases in which CI or other testing processes could be fetching different releases than what the user has on their local machine.

@sambacha sambacha added the T-bug Type: bug label Feb 8, 2024
@gakonst gakonst added this to Foundry Feb 8, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Feb 8, 2024
@tomholford
Copy link

Could this be related?

#7081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-releases Area: releases/packaging T-bug Type: bug
Projects
Status: Todo
Development

No branches or pull requests

3 participants