Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(cast): resolve-name and lookup-address ENS commands do not work #7759

Closed
2 tasks done
emo-eth opened this issue Apr 23, 2024 · 1 comment · Fixed by #7765
Closed
2 tasks done

bug(cast): resolve-name and lookup-address ENS commands do not work #7759

emo-eth opened this issue Apr 23, 2024 · 1 comment · Fixed by #7765
Labels
T-bug Type: bug

Comments

@emo-eth
Copy link
Contributor

emo-eth commented Apr 23, 2024

Component

Cast

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (008922d 2024-04-23T00:22:15.514185000Z)

What command(s) is the bug in?

cast lookup-address, cast

Operating System

macOS (Apple Silicon)

Describe the bug

These commands used to work. They no longer do.

❯ cast lookup-address 0x28679A1a632125fbBf7A68d850E50623194A709E
<null>
❯ cast lookup-address 0x333601a803CAc32B7D17A38d32c9728A93b422f4
<null>
❯ cast resolve-name emo
0x0000000000000000000000000000000000000000
❯ cast resolve-name slokh
0x0000000000000000000000000000000000000000

See: https://app.ens.domains/slokh.eth https://app.ens.domains/emo.eth

For whatever it's worth, when passing the --verify flag, which cast says does the following: "Perform a reverse lookup to verify that the name is correct."

❯ cast resolve-name -v emo
The application panicked (crashed).
Message:  assertion `left == right` failed: forward lookup verification failed. got , expected emo
  left: ""
 right: "emo"
@emo-eth emo-eth added the T-bug Type: bug label Apr 23, 2024
@emo-eth emo-eth changed the title bug(cast): resolve-name and lookup-address commands do not work bug(cast): resolve-name and lookup-address ENS commands do not work Apr 23, 2024
@DaniPopes
Copy link
Member

DaniPopes commented Apr 23, 2024

Note that just "emo" still won't work after #7765, we always required the full name string.

The error message would generically say "resolver not found", so this could be improved, or alternatively we can default any name that does not contain dots "." to ".eth".
I'll leave this for another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants