Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract forked backend and db to a standalone repo #8193

Closed
mattsse opened this issue Jun 18, 2024 · 3 comments · Fixed by #8329
Closed

Extract forked backend and db to a standalone repo #8193

mattsse opened this issue Jun 18, 2024 · 3 comments · Fixed by #8329
Assignees
Labels
good first issue Good for newcomers T-feature Type: feature

Comments

@mattsse
Copy link
Member

mattsse commented Jun 18, 2024

Component

Forge

Describe the feature you would like

This type doesn't really depend on any foundry-specific types

/// Handles an internal provider and listens for requests.
///
/// This handler will remain active as long as it is reachable (request channel still open) and
/// requests are in progress.
#[must_use = "futures do nothing unless polled"]
pub struct BackendHandler<T, P> {

only:

use crate::{
backend::{DatabaseError, DatabaseResult},
fork::{cache::FlushJsonBlockCacheDB, BlockchainDb},
};

which can also be moved or removed.

TODO

Additional context

No response

@mattsse mattsse added T-feature Type: feature good first issue Good for newcomers labels Jun 18, 2024
@teodorstupnicki
Copy link

hey @mattsse, I would like to give this one a try. Just want to clarify some stuff - this new repo is going to be a submodule of this one?

@mattsse
Copy link
Member Author

mattsse commented Jun 21, 2024

we will do this in a few steps

  1. copy current implementation to crate https://github.com/foundry-rs/alloy-fork-db
  2. some touchups maybe
  3. replace in foundry by pulling it in as a dependency

@teodorstupnicki
Copy link

thanks, understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers T-feature Type: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants