Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debt(forge verify-bytecode): add additional regression tests #8203

Closed
mds1 opened this issue Jun 19, 2024 · 1 comment
Closed

debt(forge verify-bytecode): add additional regression tests #8203

mds1 opened this issue Jun 19, 2024 · 1 comment
Assignees
@yash-atreya
Labels
C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check T-debt Type: code debt
Milestone
v1.0.0

Comments

@mds1
Copy link
Collaborator

mds1 commented Jun 19, 2024 

          We should also add a test to prevent regression in the future, since existing tests did not catch this

Originally posted by @mds1 in #8200 (comment)
@zerosnacks zerosnacks added C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check labels Jun 27, 2024
@zerosnacks zerosnacks changed the title test: add forge verify-bytecode test debt(forge verify-bytecode): add additional tests Jul 16, 2024
@zerosnacks zerosnacks added the T-debt Type: code debt label Jul 16, 2024
@zerosnacks zerosnacks changed the title debt(forge verify-bytecode): add additional tests debt(forge verify-bytecode): add additional regression tests Jul 16, 2024
@zerosnacks zerosnacks mentioned this issue Jul 24, 2024
Merged
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@yash-atreya
Copy link
Member

Tests added as part of #8510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-atreya yash-atreya

Labels
C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check T-debt Type: code debt
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@mds1 @yash-atreya @zerosnacks