bug(forge verify-contract): --verifier-url doesn't change the URL that the contract is submitted for verification

[rori4]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (ba9fa20 2024-06-24T00:23:20.410766000Z)

What command(s) is the bug in?

forge verify-contract $address $contract_name --verifier-url $verifierUrl --etherscan-api-key $VERIFIER_API_KEY --retries 10 --delay 10 --watch

Operating System

macOS (Apple Silicon)

Describe the bug

When running a manual contract verification and the passed verfifier-url is one it still defaults to Etherscan's.

Submitted contract for verification:
        Response: `OK`
        GUID: `0xc678dc1bb9f0d78b42c125633bc2daf726fdef1f`
        URL: https://etherscan.io/address/0xc678dc1bb9f0d78b42c125633bc2daf726fdef1f
Contract verification status:
...

Although I have passed another url

When a contract has been verified at creation time there is no issue like that

[mattsse]

ah this is actually a bug with how we display the URL:

which does not take into account the API url

foundry/crates/verify/src/etherscan/mod.rs

Line 122 in 32f01e3

etherscan.address_url(args.address)

foundry/crates/verify/src/etherscan/mod.rs

Line 275 in 32f01e3

.with_url(base_url.unwrap_or(api_url))?

#4151

which falls back to the known explorer URL in this case etherscan...
not sure if there's a way to guess the explorer URL from the API url

which verifier URL are you using?