-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(forge verify-bytecode
): partial bytecode verification not working as expected
#8255
Comments
@zerosnacks @yash-atreya When can we expect a fix for this? It's a tool we would like to use on internally. Right now, it's not in a condition that we can reliably say we trust. |
@zerosnacks @yash-atreya The OptimismMintableERC20Factory.sol contract doesn't verify as I'd expect against the given optimism repo commit Expected Result: [
{"bytecode_type":"creation","matched":true,"verification_type":"partial"},
{"bytecode_type":"runtime","matched":true,"verification_type":"partial"}
] Actual Result: cd optimism/packages/contracts-bedrock
rm -rf lib && git checkout e6ef3a900c42c8722e72c2e2314027f85d12ced5 && forge clean && forge build Run the verify script:
Output of the script: [
{
"bytecode_type": "creation",
"matched": true,
"verification_type": "partial"
},
{
"bytecode_type": "runtime",
"matched": false,
"verification_type": "full",
"message": "Runtime code did not match - this may be due to varying compiler settings"
}
] |
@yash-atreya Thanks - I don't think #8402 should close this issue but it's good to get that json print message fixed 👍🏻 |
forge verify-bytecode
): partial bytecode verification not working as expected
@yash-atreya Can confirm all test cases listed above are now working as expected. Thanks. |
Component
Forge
Have you ensured that all of these are up to date?
What version of Foundry are you on?
forge verify-bytecode "$address" "$contract_name" --rpc-url "$MAINNET_RPC_URL" --json
What command(s) is the bug in?
forge verify-bytecode
Operating System
macOS (Apple Silicon)
Describe the bug
Steps to reproduce
Notice that SystemConfig has completely different source code at each of these optimism repo tagged commits:
Actual Results
First
forge verify-bytecode
command output with tagop-contracts/v1.3.0
:Second
forge verify-bytecode
command output with tagop-contracts/v1.2.0
:Expected Results
The text was updated successfully, but these errors were encountered: