Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge coverage doesn't recognize require with custom error branches #8279

Closed
2 tasks done
Tracked by #4442
anajuliabit opened this issue Jun 27, 2024 · 3 comments
Closed
2 tasks done
Tracked by #4442
Labels
C-forge Command: forge Cmd-forge-coverage Command: forge coverage T-bug Type: bug

Comments

@anajuliabit
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (6179312 2024-06-10T00:18:46.177980000Z)

What command(s) is the bug in?

forge coverage --ir-minimum

Operating System

macOS (Apple Silicon)

Describe the bug

Solidity 0.8.26 introduce a new overload require(bool, Error) that allows usage of require functions with custom errors. This feature is available in the via-ir pipeline only.

Forge coverage doesn't recognize the require branches when using with custom error.

@anajuliabit anajuliabit added the T-bug Type: bug label Jun 27, 2024
@zerosnacks zerosnacks added C-forge Command: forge Cmd-forge-coverage Command: forge coverage labels Jun 28, 2024
@gnapoli23
Copy link

I have the same problem while running forge doc.

@gnapoli23
Copy link

gnapoli23 commented Jul 4, 2024

FYI: by looking at this commit, the legacy pipeline is still in the develop branch -> ethereum/solidity@06c27a5
And will be available in the next release: ethereum/solidity#15214 (comment)

@grandizzy
Copy link
Collaborator

this was fixed with #4294 and will be followed up as branch coverage in #8423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-coverage Command: forge coverage T-bug Type: bug
Projects
None yet
Development

No branches or pull requests

4 participants