fix: vm rpc encoding #8288
Merged
fix: vm rpc encoding #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah, I think people might already rely on |
|
right, the issue in #8287 is for fixed bytes (eth_getStorageAt), I changed the fix and mapped those to |
DaniPopes
reviewed
Jun 28, 2024
crates/cheatcodes/src/evm/fork.rs
Outdated
| { | ||
| DynSolValue::FixedBytes(bytes, _) => { | ||
| // converted fixed bytes to bytes to prevent evm encoding issues: <https://github.com/foundry-rs/foundry/issues/8287> | ||
| DynSolValue::Bytes(bytes.to_vec()) |
There was a problem hiding this comment.
this will be vec![_; 32] for bytes31, bytes30 ... is this right?
There was a problem hiding this comment.
bytes.as_slice()[..size].to_vec()?
|
Does the same apply to Address? |
|
maybe, but I'm not aware of any rpc call that returns an address, but I've added it |
DaniPopes
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8287
@DaniPopes @klkvr I'm not sure what the appropriate behaviour here would be, but I think ensuring the cheatcode returns the abiencoded rpc response as abi bytes makes sense, but maybe we don't double encode if the
DynSolValueis alreadyBytes?I guess this breaks existing tests, maybe this should really just convert dynsolvariants that don't encode to bytes?