Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/ethereum/go-ethereum/issues/22041 #848

Closed
1 of 2 tasks
itsdevbear opened this issue Mar 6, 2022 · 2 comments
Closed
1 of 2 tasks

https://github.com/ethereum/go-ethereum/issues/22041 #848

itsdevbear opened this issue Mar 6, 2022 · 2 comments
Labels
C-forge Command: forge Cmd-forge-build Command: forge build T-bug Type: bug

Comments

@itsdevbear
Copy link

itsdevbear commented Mar 6, 2022

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.1.0 (2ddc47e 2022-03-02T00:34:52.877001+00:00)

What command(s) is the bug in?

forge build

Operating System

darwin/arm64

Describe the bug

Ah ser Georgio, I have come again with more geth abi.ABI issues.

panic: json: cannot unmarshal array into Go struct field jsonCompiledContract.ABI of type string

goroutine 1 [running]:
github.com/berachain/core/solidity.init.0()
	/Users/dev/bc/core/solidity/contracts.go:52 +0xb4
panic: json: cannot unmarshal array into Go struct field jsonCompiledContract.ABI of type string

Maybe related to: ethereum/go-ethereum#22041, it looks as if geth expects a string, could be out to lunch but thought I would take a look.

Also the new "bytecode" struct, and removal of "bin" from the output definitely botches things, if trying to make the abi output of forge compatible with geth data structures.

@itsdevbear itsdevbear added the T-bug Type: bug label Mar 6, 2022
@onbjerg onbjerg added C-forge Command: forge Cmd-forge-build Command: forge build labels Mar 7, 2022
@onbjerg onbjerg added this to Foundry Apr 17, 2022
@onbjerg onbjerg moved this to Todo in Foundry Apr 17, 2022
@onbjerg
Copy link
Collaborator

onbjerg commented Apr 18, 2022

@itsdevbear Hey! The artifacts have changed somewhat, but maybe you can use --extra-output and --extra-output-files to get your desired result? See here https://book.getfoundry.sh/reference/forge/forge-build.html

@onbjerg onbjerg moved this from Todo to May be solved in Foundry Apr 18, 2022
@onbjerg
Copy link
Collaborator

onbjerg commented Jun 21, 2022

Closed due to inactivity - feel free to ping if you need a reopen :)

@onbjerg onbjerg closed this as completed Jun 21, 2022
Repository owner moved this from May be solved to Done in Foundry Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-build Command: forge build T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

2 participants