Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): upgrade default evm_version to cancun #8614

Open
zerosnacks opened this issue Aug 6, 2024 · 0 comments
Open

feat(config): upgrade default evm_version to cancun #8614

zerosnacks opened this issue Aug 6, 2024 · 0 comments
Labels
A-config Area: config post-v1 Temporary label to track features we want to tackle after v1 T-blocked Type: blocked T-feature Type: feature T-likely-breaking Type: requires changes that can be breaking T-to-discuss Type: requires discussion

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Aug 6, 2024

Component

Other (please describe)

Describe the feature you would like

We should evaluate whether it already makes sense to default to either: cancun (13 Mar 2024) or shanghai (12 Apr 2023) from paris (15 Sep 2022). (source)

The current configuration is:

evm_version = "paris"

The table of https://www.evmdiff.com/features?feature=opcodes shows tstore and tload are not supported on Avalance and Linea but is available on the other rollups. The current support of the entire cancun upgrade on L2s seems largely there, other EVM compatible chains have less support.

For 1.0 I think it also makes sense to establish an expectation that the default we set trails by x months.

Additional context

Considering this is a breaking change and most users have possibly not specified an evm_version this change can introduce unintended side effects.

It may make sense to pin to paris for 1.0 and apply the breaking changes post-release.

@zerosnacks zerosnacks added T-feature Type: feature A-config Area: config T-blocked Type: blocked T-to-discuss Type: requires discussion T-likely-breaking Type: requires changes that can be breaking labels Aug 6, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Aug 6, 2024
@jenpaff jenpaff added the post-v1 Temporary label to track features we want to tackle after v1 label Sep 24, 2024
@jenpaff jenpaff removed this from the v1.0.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config Area: config post-v1 Temporary label to track features we want to tackle after v1 T-blocked Type: blocked T-feature Type: feature T-likely-breaking Type: requires changes that can be breaking T-to-discuss Type: requires discussion
Projects
None yet
Development

No branches or pull requests

2 participants