forge create --verify "already verified"

[adraffy]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (5c69a9d 2024-10-28T00:23:24.836557329Z)

What command(s) is the bug in?

forge create

Operating System

Linux

Describe the bug

forge create CONTRACT --verify --private-key $PRIVATE_KEY --rpc-url https://rpc.ankr.com/eth_sepolia --etherscan-api-key $ETHERSCAN_KEY always prints "is already verified. Skipping verification."

---

With RUST_LOG=trace

2024-10-28T19:46:15.432798Z DEBUG alloy_provider::heart: notifying tx=0x...
2024-10-28T19:46:15.432810Z DEBUG alloy_provider::heart: updating latest block block_height=6965098
2024-10-28T19:46:15.578924Z TRACE hyper_util::client::legacy::pool: put; add idle connection for ("https", api-sepolia.etherscan.io)
2024-10-28T19:46:15.578968Z DEBUG hyper_util::client::legacy::pool: pooling idle connection for ("https", api-sepolia.etherscan.io)
Contract [src/Namespace.sol:Namespace] "0x..." is already verified. Skipping verification.
2024-10-28T19:46:15.579599Z TRACE mio::poll: deregistering event source from poller

With etherscan v2 endpoint --verifier-url "https://api.etherscan.io/v2/api"

Failed to deserialize content: expected value at line 1 column 1
Missing or unsupported chainid parameter (required for v2 api)

---

Since there's no way to configure the verifier, this only supports etherscan verification?

foundry/crates/forge/bin/cmd/create.rs

Lines 335 to 365 in a428ba6

	println!("Starting contract verification...");
	let num_of_optimizations = if self.opts.compiler.optimize.unwrap_or_default() {
	self.opts.compiler.optimizer_runs
	} else {
	None
	};
	let verify = forge_verify::VerifyArgs {
	address,
	contract: Some(self.contract),
	compiler_version: None,
	constructor_args,
	constructor_args_path: None,
	num_of_optimizations,
	etherscan: EtherscanOpts { key: self.eth.etherscan.key(), chain: Some(chain.into()) },
	rpc: Default::default(),
	flatten: false,
	force: false,
	skip_is_verified_check: false,
	watch: true,
	retry: self.retry,
	libraries: self.opts.libraries.clone(),
	root: None,
	verifier: self.verifier,
	via_ir: self.opts.via_ir,
	evm_version: self.opts.compiler.evm_version,
	show_standard_json_input: self.show_standard_json_input,
	guess_constructor_args: false,
	};
	println!("Waiting for {} to detect contract deployment...", verify.verifier.verifier);
	verify.run().await

skip_is_verified_check cannot be set by forge create:

foundry/crates/verify/src/etherscan/mod.rs

Lines 65 to 75 in a428ba6

	if !args.skip_is_verified_check &&
	self.is_contract_verified(&etherscan, &verify_args).await?
	{
	println!(
	"\nContract [{}] {:?} is already verified. Skipping verification.",
	verify_args.contract_name,
	verify_args.address.to_checksum(None)
	);
	return Ok(())
	}

foundry/crates/verify/src/etherscan/mod.rs

Lines 233 to 248 in a428ba6

	async fn is_contract_verified(
	&self,
	etherscan: &Client,
	verify_contract: &VerifyContract,
	) -> Result<bool> {
	let check = etherscan.contract_abi(verify_contract.address).await;
	if let Err(err) = check {
	match err {
	EtherscanError::ContractCodeNotVerified(_) => return Ok(false),
	error => return Err(error.into()),
	}
	}
	Ok(true)
	}

The foundry-rs/block-explorers:contract_abi() call:
https://github.com/foundry-rs/block-explorers/blob/a4582e4b300e70ec7b6224c352278625a28eec8d/crates/block-explorers/src/contract.rs#L364-L395

[grandizzy]

@adraffy the verifier URL can be configured in foundry.toml as shown in https://book.getfoundry.sh/reference/config/etherscan#etherscan:

[rpc_endpoints]
sepolia = "https://rpc.ankr.com/eth_sepolia"

[etherscan]
sepolia = { key = "KEY_HERE", url = "https://api.etherscan.io/v2/api"}

then

forge create --rpc-url sepolia --private-key $PRIVATE_KEY src/Counter.sol:Counter --verify
Submitting verification for [src/Counter.sol:Counter] 0x128Abc30357bE673C20D08756B0C1ab304623Fe4.
Encountered an error verifying this contract:
Response: `NOTOK`
Details: `Missing or unsupported chainid parameter (required for v2 api), please see https://api.etherscan.io/v2/chainlist for the list of supported chainids

For the already verified message we should probably apply same defaults to deploy as for verify args, that is

foundry/crates/script/src/verify.rs

Line 149 in a428ba6

skip_is_verified_check: true,

instead

foundry/crates/forge/bin/cmd/create.rs

Line 353 in a428ba6

skip_is_verified_check: false,