Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function coverage incorrect when using lcov 1.x #9461

Closed
2 tasks done
KholdStare opened this issue Dec 2, 2024 · 0 comments · Fixed by #9462
Closed
2 tasks done

Function coverage incorrect when using lcov 1.x #9461

KholdStare opened this issue Dec 2, 2024 · 0 comments · Fixed by #9462
Labels
Cmd-forge-coverage Command: forge coverage P-high Priority: high T-bug Type: bug

Comments

@KholdStare
Copy link
Contributor

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (ac81a53 2024-12-02T00:48:39.714560304Z)

What command(s) is the bug in?

forge coverage

Operating System

Linux

Describe the bug

After commit #9438, lcov 1.x sees double the number of total function, so function coverage is always less than 50%.

Repo that reproduces the issue: https://github.com/KholdStare/foundry-lcov-bug

CI run in that repo that fails, and shows 4 functions from lcov summary when there are only 2: https://github.com/KholdStare/foundry-lcov-bug/actions/runs/12128532756/job/33815097436

The reproduction is based off of running foundry init and running coverage. See the script: https://github.com/KholdStare/foundry-lcov-bug/blob/main/run_coverage.sh

@KholdStare KholdStare added T-bug Type: bug T-needs-triage Type: this issue needs to be labelled labels Dec 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 2, 2024
@DaniPopes DaniPopes added Cmd-forge-coverage Command: forge coverage and removed T-needs-triage Type: this issue needs to be labelled labels Dec 2, 2024
@DaniPopes DaniPopes added the P-high Priority: high label Dec 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmd-forge-coverage Command: forge coverage P-high Priority: high T-bug Type: bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants