Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): config flag to disallow use of libraries with public methods #9641

Open
mds1 opened this issue Jan 7, 2025 · 0 comments
Open

feat(config): config flag to disallow use of libraries with public methods #9641

mds1 opened this issue Jan 7, 2025 · 0 comments
Labels
A-config Area: config T-feature Type: feature

Comments

@mds1
Copy link
Collaborator

mds1 commented Jan 7, 2025

Component

Forge

Describe the feature you would like

Linked libraries are often not desirable, but often sneak in by accidentally making a single function in the library public instead of internal. This can cause issues that are hard to track down, such as unexpected contract deploys or edge case bugs, etc). It would be nice to have a flag like enable_linked_libraries = false that can be set in foundry.toml, that causes a failure during build if any contracts make use of linked libraries

Additional context

No response
@mds1 mds1 added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Jan 7, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jan 7, 2025
@zerosnacks zerosnacks added A-config Area: config and removed T-needs-triage Type: this issue needs to be labelled labels Jan 8, 2025
@yash-atreya yash-atreya changed the title feature request: config flag to disallow use of libraries with public methods feat(config): config flag to disallow use of libraries with public methods Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-config Area: config T-feature Type: feature
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mds1 @zerosnacks