feat: legacy_assertions config option
#8263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
changed the title
legacy_assertions config optionlegacy_assertions config option
DaniPopes
reviewed
Jun 27, 2024
DaniPopes
reviewed
Jun 27, 2024
| /// Whether failed assertions should revert. | ||
| pub assertions_revert: bool, | ||
|
|
||
| /// Whether `failed()` should be invoked to check if the test have failed. | ||
| pub legacy_assertions: bool, |
There was a problem hiding this comment.
we should update the book and the config crate readme
|
@DaniPopes this should be good to merge |
DaniPopes
approved these changes
Jun 28, 2024
mattsse
approved these changes
Jun 28, 2024
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Per Discord discussion, adds "legacy" behavior for assertions. If
legacy_assertionsconfig option is set, assertions will not revert and will instead produce logs and accumulate till the end of test execution.Solution
cc @DaniPopes I've enabled logic for tracking
GLOBAL_FAILURES_SLOTon cheatcodes addressCloses: #8049