Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all scarb packages to edition = "2024_07" #2651

Open
kkawula opened this issue Nov 7, 2024 · 31 comments · May be fixed by #2902
Open

Migrate all scarb packages to edition = "2024_07" #2651

kkawula opened this issue Nov 7, 2024 · 31 comments · May be fixed by #2902

Comments

@kkawula
Copy link
Member

kkawula commented Nov 7, 2024

Which components does the task require to be changed? (think hard pls)

snforge, sncast

Description

Migrate all scarb packages to support edition = "2024_07". The packages are located in various directories throughout the project, most notably (but not only!) in https://github.com/foundry-rs/starknet-foundry/tree/master/crates/forge/tests/data. To locate them, search for Scarb.toml files within the project.

Sollution:
for each Scarb package

  • change edition to "2024_07"
  • run snforge test in the package to check if the package compiles
    if not make proper changes

Additionally, rerun forge tests to check if the update did not break anything.

Related: #2632

@enehizy
Copy link

enehizy commented Nov 7, 2024

Mind if I take this issue?

@OWK50GA
Copy link

OWK50GA commented Nov 7, 2024

Could I take on this issue?

@mexes20
Copy link

mexes20 commented Nov 7, 2024

Hello, I’d like to be assigned to work on this.

ETA: 15 hours

@pheobeayo
Copy link

I'd love to give this a go.

@ShantelPeters
Copy link

Please can I be assigned to this issue

@PedroRosalba
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

How I plan on tackling this issue

@pheobeayo
Copy link

On it! thank you for the task.

@franciszekjob
Copy link
Collaborator

Hi @pheobeayo , just wanted to check out on your progress. Do you need any assistance 😄 ?

@pheobeayo
Copy link

@franciszekjob I am working on it, but how do I build successfully locally?

@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 14, 2024

but how do I build successfully locally?

Just run snforge test in the package.

@franciszekjob
Copy link
Collaborator

Hi @pheobeayo , how's the progress :) ?

@pheobeayo
Copy link

@franciszekjob still fixing the 507 bugs after changing the edition....

I have tried fixing some but still couldn't make the file public like this lib.cairo was initially like
image
but I decided to make it public like this
image
but still couldn't compile.....

Any clue to that

@franciszekjob
Copy link
Collaborator

@pheobeayo I see you're updating edition in snforge_std. I think we can address this specific package in other PR, as it may require more work. So let's limit the scope to update edition in all packages, apart of snforge_std, ok?

@pheobeayo pheobeayo mentioned this issue Nov 17, 2024
4 tasks
@pheobeayo
Copy link

okay

@pheobeayo
Copy link

@franciszekjob Kindly check out the PR I created yesterday, I updated the edition in all packages apart from the snforge_std

@kkawula kkawula changed the title Migrate all scarb packages to support edition = "2024_07" Migrate all scarb packages to edition = "2024_07" Dec 20, 2024
@Nanle100
Copy link

Can I take care of this issue?

@ryzen-xp
Copy link

Can I try solving this issue?

@OWK50GA
Copy link

OWK50GA commented Dec 27, 2024

May I take care of this?

@aidenwong812
Copy link

Let me handle this issue!

@olisaagbafor
Copy link

Can I handle this task?

@cptartur cptartur moved this from In Progress to Backlog in Starknet foundry Jan 14, 2025
@angeloobeta
Copy link

I will like to migrate all the packages to support edition="2024_07"

@GideonBature
Copy link

May I try my hand at this?

@cptartur
Copy link
Member

Hey, this issue will be available for taking during the ODBoost https://app.onlydust.com/hackathons/odboost-1.
If you are still interested in tacking on this one, please apply after the ODBoost start tomorrow after 3 PM CET.

@wheval
Copy link

wheval commented Jan 21, 2025

Can I start working on this?

@mimiprosper
Copy link

I would like to take this task. Am a web 2 frontend developer, a technical writer, a solidity smart contract developer/auditor and a cairo smart contract developer. Am a graduate of Starknet Cairo Bootcamp. I have successfully done tasks assigned to me in OnlyDust.
If assigned this i would complete it within 2 days.

Here are some articles i have written: https://medium.com/@emma.onyedika.okeke

@Thibrac
Copy link
Contributor

Thibrac commented Jan 22, 2025

My name is Thibrac, I've just finished school42, I'm level 8 on NG only with Cairo and I've already contributed to the cairo book several times. I'd like to do this task to train and improve before the hacker house in Denver :)

@mimiprosper
Copy link

Thanks for assigning. Am working on this task right away

@cptartur
Copy link
Member

Hey @wheval assigning this to you. If you are no longer interested in taking on this one, please let me know.

@angeloobeta
Copy link

angeloobeta commented Jan 28, 2025

@cptartur Please I will love to take up this task. I applied for it before but it was assigned to someone else.

@wheval
Copy link

wheval commented Jan 29, 2025

I'm working on it already. @cptartur

@kkawula
Copy link
Member Author

kkawula commented Jan 31, 2025

Hi @wheval, have you made any progress on this? Could you please create a draft pr with your changes?

@wheval wheval linked a pull request Feb 1, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.