-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate all scarb packages to edition = "2024_07"
#2651
Comments
Mind if I take this issue? |
Could I take on this issue? |
Hello, I’d like to be assigned to work on this. ETA: 15 hours |
I'd love to give this a go. |
Please can I be assigned to this issue |
I am applying to this issue via OnlyDust platform. My background and how it can be leveraged How I plan on tackling this issue |
On it! thank you for the task. |
Hi @pheobeayo , just wanted to check out on your progress. Do you need any assistance 😄 ? |
@franciszekjob I am working on it, but how do I build successfully locally? |
Just run |
Hi @pheobeayo , how's the progress :) ? |
@franciszekjob still fixing the 507 bugs after changing the edition.... I have tried fixing some but still couldn't make the file public like this lib.cairo was initially like Any clue to that |
@pheobeayo I see you're updating edition in |
okay |
@franciszekjob Kindly check out the PR I created yesterday, I updated the edition in all packages apart from the |
edition = "2024_07"
edition = "2024_07"
Can I take care of this issue? |
Can I try solving this issue? |
May I take care of this? |
Let me handle this issue! |
Can I handle this task? |
I will like to migrate all the packages to support |
May I try my hand at this? |
Hey, this issue will be available for taking during the ODBoost https://app.onlydust.com/hackathons/odboost-1. |
Can I start working on this? |
I would like to take this task. Am a web 2 frontend developer, a technical writer, a solidity smart contract developer/auditor and a cairo smart contract developer. Am a graduate of Starknet Cairo Bootcamp. I have successfully done tasks assigned to me in OnlyDust. Here are some articles i have written: https://medium.com/@emma.onyedika.okeke |
My name is Thibrac, I've just finished school42, I'm level 8 on NG only with Cairo and I've already contributed to the cairo book several times. I'd like to do this task to train and improve before the hacker house in Denver :) |
Thanks for assigning. Am working on this task right away |
Hey @wheval assigning this to you. If you are no longer interested in taking on this one, please let me know. |
@cptartur Please I will love to take up this task. I applied for it before but it was assigned to someone else. |
I'm working on it already. @cptartur |
Hi @wheval, have you made any progress on this? Could you please create a draft pr with your changes? |
Which components does the task require to be changed? (think hard pls)
snforge, sncast
Description
Migrate all scarb packages to support
edition = "2024_07"
. The packages are located in various directories throughout the project, most notably (but not only!) in https://github.com/foundry-rs/starknet-foundry/tree/master/crates/forge/tests/data. To locate them, search forScarb.toml
files within the project.Sollution:
for each Scarb package
snforge test
in the package to check if the package compilesif not make proper changes
Additionally, rerun forge tests to check if the update did not break anything.
Related: #2632
The text was updated successfully, but these errors were encountered: