Improve SQLite table exist checks

dissect/target/loaders/itunes.py

@@ -163,8 +163,10 @@ def derive_key(self, password: str) -> bytes:
 
     def files(self) -> Iterator[FileInfo]:
         """Iterate all the files in this backup."""
-        for row in self.manifest_db.table("Files").rows():
-            yield FileInfo(self, row.fileID, row.domain, row.relativePath, row.flags, row.file)
+
+        if table := self.manifest_db.table("Files"):
+            for row in table.rows():
+                yield FileInfo(self, row.fileID, row.domain, row.relativePath, row.flags, row.file)
 
 
 class FileInfo:

dissect/target/plugins/apps/browser/iexplore.py

@@ -36,12 +36,13 @@ def find_containers(self, name: str) -> Iterator[table.Table]:
             All ``ContainerId`` values for the requested container name.
         """
         try:
-            for container_record in self.db.table("Containers").records():
-                if record_name := container_record.get("Name"):
-                    record_name = record_name.rstrip("\00").lower()
-                    if record_name == name.lower():
-                        container_id = container_record.get("ContainerId")
-                        yield self.db.table(f"Container_{container_id}")
+            if table := self.db.table("Containers"):
+                for container_record in table.records():
+                    if record_name := container_record.get("Name"):
+                        record_name = record_name.rstrip("\00").lower()
+                        if record_name == name.lower():
+                            container_id = container_record.get("ContainerId")
+                            yield self.db.table(f"Container_{container_id}")
         except KeyError:
             pass
 

dissect/target/plugins/os/unix/esxi/_os.py

@@ -472,7 +472,11 @@ def parse_config_store(fh: BinaryIO) -> dict[str, Any]:
     db = sqlite3.SQLite3(fh)
 
     store = {}
-    for row in db.table("Config").rows():
+
+    if not (table := db.table("Config")):
+        return store
+
+    for row in table.rows():
         component_name = row.Component
         config_group_name = row.ConfigGroup
         value_group_name = row.Name

dissect/target/plugins/os/windows/activitiescache.py

@@ -116,7 +116,11 @@ def activitiescache(self) -> Iterator[ActivitiesCacheRecord]:
         for user, cache_file in self.cachefiles:
             fh = cache_file.open()
             db = sqlite3.SQLite3(fh)
-            for r in db.table("Activity").rows():
+
+            if not (table := db.table("Activity")):
+                return
+
+            for r in table.rows():
                 yield ActivitiesCacheRecord(
                     start_time=mkts(r["[StartTime]"]),
                     end_time=mkts(r["[EndTime]"]),

dissect/target/plugins/os/windows/catroot.py

@@ -217,12 +217,11 @@ def catdb(self) -> Iterator[CatrootRecord]:
             with ese_file.open("rb") as fh:
                 ese_db = EseDB(fh)
 
-                tables = [table.name for table in ese_db.tables()]
                 for hash_type, table_name in [("sha256", "HashCatNameTableSHA256"), ("sha1", "HashCatNameTableSHA1")]:
-                    if table_name not in tables:
+                    if not (table := ese_db.table(table_name)):
                         continue
 
-                    for record in ese_db.table(table_name).records():
+                    for record in table.records():
                         file_digest = digest()
                         setattr(file_digest, hash_type, record.get("HashCatNameTable_HashCol").hex())
                         catroot_names = record.get("HashCatNameTable_CatNameCol").decode().rstrip("|").split("|")

dissect/target/plugins/os/windows/notifications.py

@@ -442,23 +442,27 @@ def wpndatabase(self) -> Iterator[WpnDatabaseNotificationRecord | WpnDatabaseNot
         """
         for user, wpndatabase in self.wpndb_files:
             db = sqlite3.SQLite3(wpndatabase.open())
-
             handlers = {}
-            for row in db.table("NotificationHandler").rows():
-                handlers[row["[RecordId]"]] = WpnDatabaseNotificationHandlerRecord(
-                    created_time=datetime.datetime.strptime(row["[CreatedTime]"], "%Y-%m-%d %H:%M:%S"),
-                    modified_time=datetime.datetime.strptime(row["[ModifiedTime]"], "%Y-%m-%d %H:%M:%S"),
-                    id=row["[RecordId]"],
-                    primary_id=row["[PrimaryId]"],
-                    wns_id=row["[WNSId]"],
-                    handler_type=row["[HandlerType]"],
-                    wnf_event_name=row["[WNFEventName]"],
-                    system_data_property_set=row["[SystemDataPropertySet]"],
-                    _target=self.target,
-                    _user=user,
-                )
 
-            for row in db.table("Notification").rows():
+            if table := db.table("NotificationHandler"):
+                for row in table.rows():
+                    handlers[row["[RecordId]"]] = WpnDatabaseNotificationHandlerRecord(
+                        created_time=datetime.datetime.strptime(row["[CreatedTime]"], "%Y-%m-%d %H:%M:%S"),
+                        modified_time=datetime.datetime.strptime(row["[ModifiedTime]"], "%Y-%m-%d %H:%M:%S"),
+                        id=row["[RecordId]"],
+                        primary_id=row["[PrimaryId]"],
+                        wns_id=row["[WNSId]"],
+                        handler_type=row["[HandlerType]"],
+                        wnf_event_name=row["[WNFEventName]"],
+                        system_data_property_set=row["[SystemDataPropertySet]"],
+                        _target=self.target,
+                        _user=user,
+                    )
+
+            if not (table := db.table("Notification")):
+                return
+
+            for row in table.rows():
                 record = WpnDatabaseNotificationRecord(
                     arrival_time=wintimestamp(row["[ArrivalTime]"]),
                     expiry_time=wintimestamp(row["[ExpiryTime]"]),