Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute mcap CLI as .deb package #755

Open
james-rms opened this issue Nov 30, 2022 · 1 comment
Open

Distribute mcap CLI as .deb package #755

james-rms opened this issue Nov 30, 2022 · 1 comment
Labels
cli feature New feature or request

Comments

@james-rms
Copy link
Collaborator

Copying over from ros-tooling/rosbag2_storage_mcap#47

Proposed plan from @amacneil:

Installing it as a ros2 mcap command might be a good option to avoid conflict with an Ubuntu universe debian package.
I personally think the developer experience of having the CLI available by default is more important than the reduced footprint of one less binary on the robot, given how much else ROS installs.

But if people feel strongly about reduced runtime robot footprint, then here is a concrete proposal:

  • New mcap_cli package that installs the ros2 mcap subcommand.
  • Make the mcap_cli package a dependency of rosbag2 metapackage (but not a dependency of rosbag2_storage_mcap), so that it is installed by default (see existing rosbag2 dependencies)
  • People who do not want the mcap CLI can install the specific dependencies of rosbag2 metapackage that they need (as they presumably would already be doing if they care about minimizing on-robot footprint)
@jtbandes
Copy link
Member

Related to #675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli feature New feature or request
Development

No branches or pull requests

2 participants