Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tslib dependencies #1264

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add missing tslib dependencies #1264

merged 1 commit into from
Oct 30, 2024

Conversation

jtbandes
Copy link
Member

Changelog

TypeScript: Added missing dependencies on tslib

Docs

None

Description

Fixes #1262

When importHelpers is true in tsconfig.json (as it is by default with @foxglove/tsconfig), tslib must be a dependency.

defunctzombie
defunctzombie approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make importHelpers false for a library like mcap? Why do we need importHelpers?

@jtbandes
Copy link
Member Author

🤷 the docs on it say:

By default, these helpers are inserted into files which use them. This can result in code duplication if the same helper is used in many different modules.

So it seems like a (maybe small) code size optimization to have it turned on?

@jtbandes jtbandes merged commit ff0cb3c into main Oct 30, 2024
23 checks passed
@jtbandes jtbandes deleted the jacob/tslib branch October 30, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defunctzombie defunctzombie defunctzombie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typescript: Cannot find module 'tslib'
2 participants
@jtbandes @defunctzombie