go: use internal version string #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-rms
force-pushed
the
jrms/cli-fix-library-string
branch
8 times, most recently
from
a0acde5
to
dc29fed
Compare
james-rms
changed the title
james-rms
force-pushed
the
jrms/cli-fix-library-string
branch
from
dc29fed
to
d0daa7a
Compare
james-rms
force-pushed
the
jrms/cli-fix-library-string
branch
from
d0daa7a
to
7000cce
Compare
jtbandes
reviewed
Oct 12, 2022
james-rms
force-pushed
the
jrms/cli-fix-library-string
branch
from
338b351
to
20aa135
Compare
jtbandes
approved these changes
Oct 12, 2022
|
Yes, that's about the best we can do I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
None.
Description
With context from golang/go#29228, the result of runtime/debug.BuildInfo.Main.Version is not well defined. Here we use an internally-defined Version as our library version in all contexts. We also add a test when using a go library release tag
go/mcap/v1.2.3that the Version string is correct.This PR also changes the behaviour of
Writerto only append the existing library version if it's different from the current version. This removes the awkward behaviour ofmcap filterwhere the resulting mcap Library would bemcap go #(devel); mcap go #(devel); mcap go #(devel)....Fixes #591