Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pls upgrade client boilerplate code to react-router v6 #73

Open
kedarpethe37 opened this issue Aug 14, 2022 · 0 comments
Open

Pls upgrade client boilerplate code to react-router v6 #73

kedarpethe37 opened this issue Aug 14, 2022 · 0 comments

Comments

@kedarpethe37
Copy link

kedarpethe37 commented Aug 14, 2022 •
edited
Loading

This boilerplate is the most comprehensive and production quality boilerplates on Github and so has set high expectations for everyone. I have recommended this boilerplate to many guys.

Few suggestions:

  1. Pls upgrade to react-router v6. This will simplify boilerplate by some factor.
  2. Moment.js has been deprecated in favor of new Intl API. You can also use React Intl npm package.
  3. More descriptive and explainatory comments in server side code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kedarpethe37