-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom menu in iPhoneX #18
Comments
iOS strikes again 😬 This led me down a fun read on Webkit about safe areas in CSS. @farskid, could you visit the PR app at https://ephemeral-v2-git-improvement-iphone-safe-area-inset.fpapado1.now.sh/ and check whether the safe area is inserted? If not, we'll keep looking! |
Unfortunately it has the same problem still. |
I tweaked the bottom padding with the supports query to be larger, I think that might work now. It's still not as correct of a solution, but apparently iOS doesn't give accurate safe area insets for the home bar, unless you opt in to handling the notch manually as well. So if it works with these values, I'll merge it and look to supporting the full screen when I have a device to test. |
After #20, the more correct values should now also factor into the calculation. Though this is iOS, so I trust nothing 😅 |
Describe the bug
The iPhone X virtual home button indicator conflicts with the app's bottom navbar.
Screenshots
![image](https://user-images.githubusercontent.com/8332043/60734562-9c0b2480-9f65-11e9-8ac6-1ce638e4952b.png)
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: