Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom menu in iPhoneX #18

Open
farskid opened this issue Jul 5, 2019 · 4 comments
Open

Bottom menu in iPhoneX #18

farskid opened this issue Jul 5, 2019 · 4 comments

Comments

@farskid
Copy link

farskid commented Jul 5, 2019

Describe the bug
The iPhone X virtual home button indicator conflicts with the app's bottom navbar.

Screenshots
image

Smartphone (please complete the following information):

  • Device: iPhone X
  • OS: iOS 12
  • Browser Chrome
  • Version ¯_(ツ)_/¯
@fpapado
Copy link
Owner

fpapado commented Jul 5, 2019

iOS strikes again 😬

This led me down a fun read on Webkit about safe areas in CSS.
I have a WIP PR at: #19

@farskid, could you visit the PR app at https://ephemeral-v2-git-improvement-iphone-safe-area-inset.fpapado1.now.sh/ and check whether the safe area is inserted? If not, we'll keep looking!

@farskid
Copy link
Author

farskid commented Jul 5, 2019

Unfortunately it has the same problem still.

@fpapado
Copy link
Owner

fpapado commented Jul 6, 2019

I tweaked the bottom padding with the supports query to be larger, I think that might work now.

It's still not as correct of a solution, but apparently iOS doesn't give accurate safe area insets for the home bar, unless you opt in to handling the notch manually as well. So if it works with these values, I'll merge it and look to supporting the full screen when I have a device to test.

@fpapado
Copy link
Owner

fpapado commented Jul 7, 2019

After #20, the more correct values should now also factor into the calculation. Though this is iOS, so I trust nothing 😅
Can you have a look on the production app and see if it's changed? Might have to wait for the "new version available" message to pop up first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants